cuda_root_path: Find cuda libraries when installed with conda packages #20288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
beckerhe
approved these changes
Jan 20, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
…nda packages Imported from GitHub PR #20288 This fix emerged when looking in solving jax-ml/jax#24604 . In a nutshell, the official cuda package for conda (both in the `conda-forge` and `nvidia` conda channels) install the CUDA libraries in a different location with respect to PyPI packages, so the logic to find them needs to be augmented to be able to find the CUDA libraries when installed from conda packages. I did not tested this with a tensorflow build, but probably this will also help in solving tensorflow/tensorflow#56927 . xref: conda-forge/tensorflow-feedstock#408 xref: conda-forge/jaxlib-feedstock#288 Copybara import of the project: -- a2ce85c by Silvio Traversaro <[email protected]>: cuda_root_path: Find cuda libraries when installed with conda packages Merging this change closes #20288 FUTURE_COPYBARA_INTEGRATE_REVIEW=#20288 from traversaro:fixloadcudaconda a2ce85c PiperOrigin-RevId: 717411600
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jan 20, 2025
…nda packages Imported from GitHub PR openxla/xla#20288 This fix emerged when looking in solving jax-ml/jax#24604 . In a nutshell, the official cuda package for conda (both in the `conda-forge` and `nvidia` conda channels) install the CUDA libraries in a different location with respect to PyPI packages, so the logic to find them needs to be augmented to be able to find the CUDA libraries when installed from conda packages. I did not tested this with a tensorflow build, but probably this will also help in solving #56927 . xref: conda-forge/tensorflow-feedstock#408 xref: conda-forge/jaxlib-feedstock#288 Copybara import of the project: -- a2ce85cf9df1ede3f3c1843ede55d4c76673910e by Silvio Traversaro <[email protected]>: cuda_root_path: Find cuda libraries when installed with conda packages Merging this change closes #20288 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#20288 from traversaro:fixloadcudaconda a2ce85cf9df1ede3f3c1843ede55d4c76673910e PiperOrigin-RevId: 717411600
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
…nda packages Imported from GitHub PR #20288 This fix emerged when looking in solving jax-ml/jax#24604 . In a nutshell, the official cuda package for conda (both in the `conda-forge` and `nvidia` conda channels) install the CUDA libraries in a different location with respect to PyPI packages, so the logic to find them needs to be augmented to be able to find the CUDA libraries when installed from conda packages. I did not tested this with a tensorflow build, but probably this will also help in solving tensorflow/tensorflow#56927 . xref: conda-forge/tensorflow-feedstock#408 xref: conda-forge/jaxlib-feedstock#288 Copybara import of the project: -- a2ce85c by Silvio Traversaro <[email protected]>: cuda_root_path: Find cuda libraries when installed with conda packages Merging this change closes #20288 FUTURE_COPYBARA_INTEGRATE_REVIEW=#20288 from traversaro:fixloadcudaconda a2ce85c PiperOrigin-RevId: 717411600
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jan 20, 2025
…nda packages Imported from GitHub PR openxla/xla#20288 This fix emerged when looking in solving jax-ml/jax#24604 . In a nutshell, the official cuda package for conda (both in the `conda-forge` and `nvidia` conda channels) install the CUDA libraries in a different location with respect to PyPI packages, so the logic to find them needs to be augmented to be able to find the CUDA libraries when installed from conda packages. I did not tested this with a tensorflow build, but probably this will also help in solving #56927 . xref: conda-forge/tensorflow-feedstock#408 xref: conda-forge/jaxlib-feedstock#288 Copybara import of the project: -- a2ce85cf9df1ede3f3c1843ede55d4c76673910e by Silvio Traversaro <[email protected]>: cuda_root_path: Find cuda libraries when installed with conda packages Merging this change closes #20288 PiperOrigin-RevId: 717440484
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix emerged when looking in solving jax-ml/jax#24604 . In a nutshell, the official cuda package for conda (both in the
conda-forgeandnvidiaconda channels) install the CUDA libraries in a different location with respect to PyPI packages, so the logic to find them needs to be augmented to be able to find the CUDA libraries when installed from conda packages.I did not tested this with a tensorflow build, but probably this will also help in solving tensorflow/tensorflow#56927 .
xref: conda-forge/tensorflow-feedstock#408
xref: conda-forge/jaxlib-feedstock#288